[alsa-devel] [PATCH] ASoC: OMAP: Don't try to set unsupported OMAP_DMA_DATA_BURST_16 on OMAP1

Jarkko Nikula jhnikula at gmail.com
Wed Oct 21 21:16:07 CEST 2009

On Wed, 21 Oct 2009 20:35:40 +0200
Janusz Krzysztofik <jkrzyszt at tis.icnet.pl> wrote:

> +	if (cpu_class_is_omap1())
> +		return 0;
> +
>  	omap_set_dma_src_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
>  	omap_set_dma_dest_burst_mode(prtd->dma_ch, OMAP_DMA_DATA_BURST_16);
I would have implemented this by "if (!cpu_class_is_omap1())
{..._burst_mode}" for making sure that no new OMAP1 error is introduced
in the future if there is need to add some common stuff after those
burst_mode calls and probably compiler can better optimize away those
burst_mode calls for OMAP1 builds.


More information about the Alsa-devel mailing list