[alsa-devel] [PATCH 5/8] board-rx51-peripherals: split vaux3 and vmmc2 supplies
eduardo.valentin at nokia.com
Mon Oct 12 10:08:58 CEST 2009
On Fri, Oct 09, 2009 at 01:03:47PM +0200, Mark Brown wrote:
> On Fri, Oct 09, 2009 at 09:45:29AM +0300, Eduardo Valentin wrote:
> > On Thu, Oct 08, 2009 at 03:21:10PM +0200, Mark Brown wrote:
> > > On Thu, Oct 08, 2009 at 02:58:54PM +0300, Eduardo Valentin wrote:
> > > I may have missed it but I don't see rx51_vmmc2_supply added back
> > > anywhere in the patch?
> > yes. That's because this patch is just to split then. As you can see
> > in current code, this structure, rx51_vmmc2_supply, is actually used
> > by rx51_vaux3_mmc and rx51_vmmc2. So the idea is to have separated
> > supplies for each one. This patch just splits then. Patch 0006 of this
> > series adds usage of rx51_vmmc2_supply.
> Might be an idea to change the description to something like "add a
> separate structure for...", it wasn't 100% clear what was going on
> (probably because the diff doesn't include sufficient context to make it
> > > ...using dev_name rather than dev should avoid the need to do this at
> > > runtime.
I'm afraid using dev_name is not that easy. The mmc driver generates device
name at runtime. That's why this board file setups .dev at runtime as well.
rx51_twlgpio_setup -> twl4030_mmc_init -> omap2_init_mmc
So, changing this supply to something static using .dev_name it is not
possible with current code. That would need refactoring the whole mmc and
hsmmc setup. And the device naming procedure is dependent on cpu as well.
> > I see your point. As mentioned above, this patch is just a split.
> > I just added rx51_vaux3_supply to be owned by rx51_vaux3_mmc. And
> > let the code behavior as it was before.
> > Maybe your proposal must be sent into a separated patch/patch series (?).
> Yes, it's definately a separate patch - might be good to put it into the
> series before this one.
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the Alsa-devel