[alsa-devel] [PATCH - try2] ASoC: TPA6130A2 amplifier driver

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Oct 9 20:15:38 CEST 2009

On Fri, Oct 09, 2009 at 03:55:41PM +0300, Peter Ujfalusi wrote:

> +struct i2c_client *tpa6130a2_client;

This should be static.

> +void tpa6130a2_power(int power)
> +{

This should either be static or have an EXPORT_SYMBOL_GPL() - I'd expect
the former since this is being managed via DAPM.

> +	pdata = (struct tpa6130a2_platform_data *)client->dev.platform_data;

You should never need to cast away from void, and doing so can mask
actual errors.

> +fail:
> +       kfree(data);
> +       i2c_set_clientdata(tpa6130a2_client, NULL);
> +       tpa6130a2_client = 0;

The kernel coding style is to use an explict NULL.

Other than that everything looks good so I've applied this with the
fixes I noted above.  If you could send a followup patch for the
tpa6130a2_power export/static thing that'd be good.


More information about the Alsa-devel mailing list