[alsa-devel] [PATCH 8/8] ASoC: tpa6130a2: Control vdd using regulator framework

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Oct 8 15:43:33 CEST 2009

On Thu, Oct 08, 2009 at 02:58:57PM +0300, Eduardo Valentin wrote:

> +	data->regulator = regulator_get(dev, "vdd");
> +	if (IS_ERR(data->regulator)) {
> +		dev_info(dev, "Could not get regulator for vdd. "
> +					"Executing without regulator.\n");
> +			data->regulator = NULL;
> +	}

Similar comments to the previous patch apply to this driver - regulator
usage should be unconditional, error messages should not be split over
multiple lines and you should represent all the supplies separately (it
looks like there's both VDD and CPVSS required here, for example) to
avoid future surprises.
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

More information about the Alsa-devel mailing list