[alsa-devel] [PATCH 1/31] HDA patch_via.c: Remove IS_VT17xx_VENDORID macro

Takashi Iwai tiwai at suse.de
Thu Oct 8 09:36:41 CEST 2009


At Thu, 8 Oct 2009 15:28:17 +0800,
Li Bo wrote:
> 
> On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai <tiwai at suse.de> wrote:
> > At Thu, 8 Oct 2009 14:22:07 +0800,
> > Li Bo wrote:
> >>
> >> On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai <tiwai at suse.de> wrote:
> >> > At Thu, 8 Oct 2009 14:11:42 +0800,
> >> > Li Bo wrote:
> >> >>
> >> >> On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai <tiwai at suse.de> wrote:
> >> >> > At Thu, 8 Oct 2009 13:27:49 +0800,
> >> >> > Li Bo wrote:
> >> >> >>
> >> >> >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
> >> >> >>
> >> >> >> IS_VT17*_VENDORID macros are used nowhere, so clean them up.
> >> >> >>
> >> >> >> Signed-off-by: Lydia Wang <lydiawang at viatech.com.cn>
> >> >> >
> >> >> > Li, could you add your sign-off, too, when you handle the patches?
> >> >> > Otherwise I can't merge them.
> >> >> >
> >> >> >
> >> >> > thanks,
> >> >> >
> >> >> > Takashi
> >> >> >
> >> >>
> >> >> Is that OK signed-off with LoganLi at viatech.com.cn with this gmail
> >> >> liboat at gamil.com? LoganLi at viatech.com.cn is my company's email.
> >> >> If not, I'll will resend them tomorrow when I go back to company.
> >> >
> >> > I don't care which address you use (and I don't know whether it
> >> > matters your employer).  It's fully your choice.
> >> >
> >> > But, if the signed address is different from the mail sender, add a
> >> > line "From: YOUR NAME <your at mail>" at the beginning of the patch
> >> > explicitly.
> >> >
> >> >
> >> > thanks,
> >> >
> >> > Takashi
> >> >
> >> I just randomly use my gmail. I will resend them tomorrow, thank you for
> >> teaching me:)
> >
> > Well, I was unclear in the text above.
> >
> > You can send patches with the sign-off of your company account even
> > from your gmail account.  Just add "From:" line with your company
> > account in the patch text so that I can pick up the right address.
> >
> >
> > Takashi
> >
> like this?
> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
> 
> IS_VT17*_VENDORID macros are used nowhere, so clean them up.
> 
> Signed-off-by: Lydia Wang <lydiawang at viatech.com.cn>
> Signed-off-by: Logan Li <loganli at viatech.com.cn>
> From: Li Bo <liboat at gmail.com>

No, add your sign-off address, i.e. "Logan Li
<loganli at viatech.com.cn>" to From: line, and put it at the beginning
of the patch.

But, now another question is who is the original author of the patch.
Is it Lydia?  Then the "From:" line should be of Lydia.  In that way,
we can clarify who is the original author.

If you changed something from the original patch, better to mention
in the changelog text, too.

And, at best, add "Subject:" to each subject line, so that git-am can
pick up properly.  So, the patch head would look like:

  From: Lydia Wang <lydiawang at viatech.com.cn>
  Subject: ALSA: HDA VIA: Fix blah blah

  blah blah
  ...

  Changed foo bar by Logan Li.
  blah blah
  ...

  Signed-off-by: Lydia Wang <lydiawang at viatech.com.cn>
  Signed-off-by: Logan Li <loganli at viatech.com.cn>


thanks,

Takashi


More information about the Alsa-devel mailing list