[alsa-devel] ice1724 - Changing Level Meters from MIXER to PCM?

Pavel Hofman pavel.hofman at ivitera.com
Tue Oct 6 10:21:20 CEST 2009


Following your discussion on moving low-level controls from MIXER to PCM
types, I would like to suggest the following two patches:

diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index 3896fb9..28ca8a4 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -2160,7 +2160,7 @@ static int snd_vt1724_pro_peak_get(struct
snd_kcontrol *kcontrol,

 static struct snd_kcontrol_new snd_vt1724_mixer_pro_peak __devinitdata = {
-       .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+       .iface = SNDRV_CTL_ELEM_IFACE_PCM,
        .name = "Multi Track Peak",
        .access = SNDRV_CTL_ELEM_ACCESS_READ |
        .info = snd_vt1724_pro_peak_info,

diff --git a/envy24control/levelmeters.c b/envy24control/levelmeters.c
index 3bf1a94..9bdaace 100644
--- a/envy24control/levelmeters.c
+++ b/envy24control/levelmeters.c
@@ -262,7 +262,7 @@ void level_meters_reset_peaks(GtkButton *button,
gpointer da
 void level_meters_init(void)
-       snd_ctl_elem_value_set_interface(peaks, SND_CTL_ELEM_IFACE_MIXER);
+       snd_ctl_elem_value_set_interface(peaks, SND_CTL_ELEM_IFACE_PCM);
        snd_ctl_elem_value_set_name(peaks, "Multi Track Peak");

The point is these controls are read-only, display incorrectly in
alsamixer, and are very confusing for majority of users who do not read
envy24 datasheet and the source code.

Thanks for considering this IMO useful change.



More information about the Alsa-devel mailing list