[alsa-devel] A few fix patches for ASoC

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Oct 1 17:24:43 CEST 2009


On Thu, Oct 01, 2009 at 09:04:32AM +0200, Takashi Iwai wrote:

> commit c877c25170e2655d519b29e91d6c91d5d1a72a6f
> Author: Takashi Iwai <tiwai at suse.de>
> Date:   Thu Oct 1 08:33:47 2009 +0200
> 
>     ASoC: Fix dependency of CONFIG_SND_PXA2XX_SOC_IMOTE2

Hrm.  This one applies to every board which doesn't use AC97 (some will
need SPI but it's the same deal for that).  It should probably also be a
dependency on the actual I2C controller driver rather than I2C in
general since the driver isn't going to do anything if the I2C device
isn't actually able to come up, though that'd prevent people doing
strange stuff like having the I2C bus driver modular and the audio built
in.

I'll have a look at doing this properly later, though probably not
targetted at 2.6.32 since it doesn't seem to be something people hit
often.  An easier way of approaching it would be to put ifdefs into the
all CODEC drivers for their bus access, even if they only support one
bus type.  That'd keep build testing happy which I think is the main
thing here.


More information about the Alsa-devel mailing list