[alsa-devel] [PATCH] ascenario: Add scenario support to alsa-lib

[Stefan Schmidt]

Hello.

On Thu, 2009-10-01 at 14:24, Mark Brown wrote:
> On Thu, Oct 01, 2009 at 03:19:48PM +0200, Stefan Schmidt wrote:
> > On Thu, 2009-10-01 at 13:28, Mark Brown wrote:
> 
> > > > +/** Scenario ID's
> > > > + *
> > > > + * Standard Scenario ID's - Add new scenarios at the end.
> > > > + */
> 
> > > Extra 's here.
> 
> > That way?
> > /**
> >  * Scenario ID's
> >  *
> >  * Standard Scenario ID's - Add new scenarios at the end.
> >  */
> 
> There shouldn't be any 's in the above at all ("Scenarios IDs" instead),
> those are just plain plurals - just a trivial grammar nit.

Ah, non-native speaker problem. :) Fixed.

> > > I guess the idea is that in the future this will be removed and the
> > > scenario API will use inotify or similar to pick up changes.
> 
> > Indeed. Certainly a Todo item for later enhancements. Do you guys prefer such
> > todo items in the code or noted somewhere else?
> 
> I have no great preference either way.

Hmm, will think about it.

regards
Stefan Schmidt