[alsa-devel] [PATCH] ALSA: ASoc: pxa/raumfeld: adopt new snd_soc_dai_set_pll() API
daniel at caiaq.de
Mon Nov 30 14:06:37 CET 2009
On Mon, Nov 30, 2009 at 12:55:43PM +0000, Mark Brown wrote:
> On Mon, Nov 30, 2009 at 11:12:44AM +0100, Daniel Mack wrote:
> > This is needed for recent changes in the for-2.6.33 branch.
> Which changes?
snd_soc_dai_set_pll() takes an additional argument now.
> > - ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk);
> > + ret = snd_soc_dai_set_pll(cpu_dai, 0, 0, clk, clk);
> > if (ret < 0)
> > return ret;
> This looks wrong - why would you configure a PLL to produce the same
> frequency as is being input? I suspect you're trying to update for the
> addition of the additional source argument to set_pll()...
Ah, right. The pxa-ssp code doesn't pay attention to either argument,
hence I didn't notice. Thanks!
More information about the Alsa-devel