[alsa-devel] [PATCH] OMAP: Exporting functions doing common register access
paul at pwsan.com
Wed Nov 18 11:40:40 CET 2009
On Wed, 18 Nov 2009, Aggarwal, Anuj wrote:
> [Aggarwal, Anuj] Any comments on this patch? Do I have to re-work this?
Yes. omap_ctrl_*() should not be exported, as mentioned earlier.
A lot of rework will be needed at some point in sound/soc/omap/ to get all
of the chip- and board-integration details out of these files. DMA
channels, IRQs, board data, etc. should all go into arch/arm/*omap*.
plat-omap/mcbsp.c needs to be moved to somewhere under drivers/ at some
point, but the platform_device setup for it should be kept under
In the interim, I would suggest that you remove the the clock source and
receiver source change functions from omap-mcbsp.c, split them into OMAP1
and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c.
Expand struct omap_mcbsp_ops to add function pointers to those functions.
Call those from soc/omap-mcbsp.c via mcbsp->pdata->ops. That way you won't
need those exports.
I don't understand how this code compiled on OMAP1 in any case, since it
doesn't have a System Control Module.
More information about the Alsa-devel