[alsa-devel] [patch] remove unnecessary null check

[Takashi Iwai]

At Wed, 18 Nov 2009 10:31:57 +0200 (SAST),
Dan Carpenter wrote:
> 
> This function is only called from snd_ctl_ioctl() and the file parameter 
> can never be null so there is no need to check it here.
> 
> We dereference file at the start of the function:
>         struct snd_card *card = file->card;
> and it confuses static checkers to dereference a pointer before 
> checking it.
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27 at gmail.com>

Thanks, applied now.


Takashi

> 
> --- orig/sound/core/control.c	2009-11-17 07:15:04.000000000 +0200
> +++ devel/sound/core/control.c	2009-11-17 07:40:30.000000000 +0200
> @@ -1120,7 +1120,7 @@
>  	    	goto __kctl_end;
>  	}
>  	if (vd->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) {
> -		if (file && vd->owner != NULL && vd->owner != file) {
> +		if (vd->owner != NULL && vd->owner != file) {
>  			err = -EPERM;
>  			goto __kctl_end;
>  		}
>