[alsa-devel] [PATCH] cs423x: update control names

[Takashi Iwai]

At Sun, 15 Nov 2009 18:34:16 +0100,
Krzysztof Helt wrote:
> 
> On Sun, 15 Nov 2009 17:00:46 +0100
> Takashi Iwai <tiwai at suse.de> wrote:
> 
> > At Sun, 15 Nov 2009 15:05:13 +0100,
> > Krzysztof Helt wrote:
> > > 
> > > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > > 
> > > Update control names to be more closer to their meaning.
> > > Change the "Mono" name to the "Beep" as this line is usually
> > > used to forward the PC beeper signal to sound card's output.
> > > Update names for both cs423x and wss.
> > > 
> > > Clean up cs4235 controls according to the cs4235 doc.
> > 
> > Does this include the renaming of Aux controls you made?
> > Or, is it another issue?
> > 
> 
> Yes. The names "AuxN" are used for the cs4235 but not for the cs4236. 
> The cs4236 have been using recommended line sources names (CD and Line in)
> instead. I changed these names to be the same for the cs4235.

OK, fair enough.

> > > Also, delete one misnamed cs4231 register define.
> > > 
> > > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > > ---
> > 
> > > It matters for the OSS layer, which does map the "Master Playback Volume"
> > > as a "Volume" control, but the "Master DAC Volume" is recognized by the OSS layer.
> > 
> > Adding more volume names to map OSS is no problem unless it conflicts
> > with other drivers.  IMO, "Master DAC" doesn't look intuitive than
> > "Master Digital".
> > 
> 
> I can revert that. The "Master DAC" is drawn in the docs as a mixer after 
> the DAC (on the DAC analog output). For me the DAC is more intutitive
> but I can revert that.

I prefer reverting it.  Changing the mixer elements unnecessarily isn't
good because it's a kind of ABI changes.

> > BTW, what would "Bypass" switch do exactly?  This is also an
> > unintuitive mixer element...
> > 
> 
> The beep bypass switch connects directly the beep input (aka mono input) 
> with the mono output (if it is used at all). The beep signal is not affected
> by the "beep playback switch" and "beep playback volume" controls then
> (it bypass the analog mixer). It is a routing switch.

OK, then it's fine to rename.


thanks,

Takashi