[alsa-devel] [PATCH 13/13] pcmcia: rework the irq_req_t typedef
marcel at holtmann.org
Wed Nov 11 21:46:03 CET 2009
> Most of the irq_req_t typedef'd struct can be re-worked quite
> (1) IRQInfo2 was unused in any case, so drop it.
> (2) IRQInfo1 was used write-only, so drop it.
> (3) Instance (private data to be passed to the IRQ handler):
> Most PCMCIA drivers using pcmcia_request_irq() to actually
> register an IRQ handler set the "dev_id" to the same pointer
> as the "priv" pointer in struct pcmcia_device. Modify the two
> exceptions (ipwireless, ibmtr_cs) to also work this waym and
> set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
> (4) Handler is to be of type irq_handler_t.
> (5) Handler != NULL already tells whether an IRQ handler is present.
> Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
> CC: netdev at vger.kernel.org
> CC: linux-bluetooth at vger.kernel.org
> CC: linux-ide at vger.kernel.org
> CC: linux-wireless at vger.kernel.org
> CC: linux-scsi at vger.kernel.org
> CC: alsa-devel at alsa-project.org
> CC: Jaroslav Kysela <perex at perex.cz>
> CC: Jiri Kosina <jkosina at suse.cz>
> CC: Karsten Keil <isdn at linux-pingi.de>
> Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
> drivers/ata/pata_pcmcia.c | 1 -
> drivers/bluetooth/bluecard_cs.c | 4 +---
> drivers/bluetooth/bt3c_cs.c | 4 +---
> drivers/bluetooth/btuart_cs.c | 4 +---
> drivers/bluetooth/dtl1_cs.c | 4 +---
for the Bluetooth parts:
Acked-by: Marcel Holtmann <marcel at holtmann.org>
More information about the Alsa-devel