[alsa-devel] [PATCH] soc-core: move setting ac97 platform data earlier than ac97 read/write

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Nov 11 12:28:18 CET 2009

On Wed, Nov 11, 2009 at 05:41:15PM +0800, Barry Song wrote:
> While probing, AC97 codec drivers generically execute the following sequence:
> snd_soc_new_ac97_codec -> snd_soc_new_pcms -> reset ac-link/read AC97 ID to
> detect ->...  -> snd_soc_init_card
> commit 474828a40f6ddab6e2a3475a19c5c84aa3ec7d60 adds platform_data to
> snd_ac97 instance. But ac97 platform data hasn't given to snd_ac97 until
> snd_soc_init_card. Then while ac97_read access platform_data of snd_ac97
> for detecting, NULL pointer oops will fire. That means old platform_data
> patch doesn't work in real-life cases.
> This patch moves the operation of setting ac97 platform_data earlier
> than ac97 reading/writing operations. Then it makes platform_data of
> AC97 become practically useful.
> Signed-off-by: Barry Song <21cnbao at gmail.com>

Applied, thanks.

More information about the Alsa-devel mailing list