[alsa-devel] [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available

Alan Cox alan at lxorguk.ukuu.org.uk
Sun Nov 8 17:50:00 CET 2009


On Sat,  7 Nov 2009 13:16:18 -0200
André Goddard Rosa <andre.goddard at gmail.com> wrote:

> On the following sentence:
>     while (*s && isspace(*s))
>         s++;

Looks fine but for one thing: it's actually shorter inline than moved
into /lib so at the very least it should be a header inline not a
function call.

Second minor comment. Although it never made it into the final ANSI C,
the proposed name (and the one used in a lot of other non Linux code for
this) is stpblk().

Alan


More information about the Alsa-devel mailing list