[alsa-devel] [PATCH] cs4236: detect chip in one pass

Takashi Iwai tiwai at suse.de
Thu Nov 5 18:20:22 CET 2009

At Thu, 5 Nov 2009 18:32:41 +0100,
Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> The cs4236 was two step detection with call to the snd_wss_free()
> between two steps. The snd_wss_free() did not free a sound device
> created in the snd_wss_create(). This caused an OOPS during module
> removal as the same sound device was released twice. The same OOPS
> happened if the cs4236 module loading failed.
> Fix this by adapting the snd_cs4236_create() to correctly work with
> chips less capable then cs4236. The snd_cs4236_create() behaves the
> same as the snd_wss_create() if the chip is less capable than the cs4236.
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> ---
> This is the third version of the patch with less code indented (smaller change).

Thanks!  Applied now.


More information about the Alsa-devel mailing list