[alsa-devel] [PATCH 1/7] S3C AUDIO: Rename s3c24xx_pcm prefix to s3c_dma

Joonyoung Shim jy0922.shim at samsung.com
Thu Nov 5 04:14:41 CET 2009


On 11/5/2009 10:34 AM, Jassi Brar wrote:
> The s3c24xx_pcm prefix for the soc_platform is inappropriate when
> some Samsung SoCs have PCM controllers which will eventually have
> drivers and hence namespace ambiguities.
> 
> To resolve naming ambiguities in future the following have been
> renamed in order
> 1) s3c24xx_pcm_dma_params -> s3c_audio_dma_params
> 2) s3c24xx_pcm_preallocate_dma_buffer -> s3c_preallocate_dma_buffer
> 3) s3c24xx_pcm_dmamask -> s3c_dmamask
> 4) s3c24xx_pcm_XXX -> s3c_dma_XXX
> 

I think that it should have a consistent prefix: s3c_audio_dma_ or
other prefix.

BTW, should we keep up s3c prefix? If we will change the prefix now, it
is a chance alterable from s3c prefix to other prefix because there is a
variety of samsung SoCs unused s3c prefix.


More information about the Alsa-devel mailing list