[alsa-devel] [PATCH] alsa: echoaudio - pci id cleanup

Tim Blechmann tim at klingt.org
Wed Nov 4 10:07:52 CET 2009

On 11/04/2009 09:25 AM, Takashi Iwai wrote:
> At Sat, 17 Oct 2009 11:48:23 +0200,
> Tim Blechmann wrote:
>> using the PCI_VENDOR_ID_MOTOROLA definition instead of the value 0x1057
>> makes code a bit cleaner.
>> Signed-off-by: Tim Blechmann <tim at klingt.org>
> Well, I'm not always fond of this.  The only merit is that you can avoid
> a typo.  But, if you look for a device from the source code from lspci,
> this kind of change makes it hard.

it helps, if this device is referred to by PCI_VENDOR_ID_MOTOROLA
instead of 0x1057, as it is done somewhere in the cardbus code ...

but since it is a rather cosmetic fix, feel free to drop the patch ...


tim at klingt.org

You don't have to call it music if the term shocks you.
  John Cage

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20091104/428be838/attachment.sig 

More information about the Alsa-devel mailing list