[alsa-devel] [PATCH V4 3/5] AC97 driver for mpc5200

Grant Likely grant.likely at secretlab.ca
Tue May 26 05:47:24 CEST 2009


On Mon, May 25, 2009 at 9:41 PM, Timur Tabi <timur at freescale.com> wrote:
> On Mon, May 25, 2009 at 5:15 PM, Jon Smirl <jonsmirl at gmail.com> wrote:
>
>> +       spin_event_timeout(1, 3, 0, rc);
>
> Ugh, don't do this.  Just use udelay!

heh; indeed.  My objection to udelay is that it burns cycles it the
test loop that could be used to decide whether or not the loop is
complete.  Not an issue when the explicit goal is to burn a fixed
number of cycles.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


More information about the Alsa-devel mailing list