[alsa-devel] [PATCH 1/2] pxa2xx-ac97-lib: move set_resetgpio to pxa27x.c

Eric Miao eric.y.miao at gmail.com
Mon May 25 12:21:40 CEST 2009

On Mon, May 25, 2009 at 5:20 PM, Dmitry Eremin-Solenikov
<dbaryshkov at gmail.com> wrote:
> The code related to set_resetgpio is pxa27x specific and should
> not be present in sound driver lib. Move it to appropriate place.
> The code is moved to arch/arm as it will be converted from (exported)
> pxa_gpio_mode() calls to use MFP which are unexported to modules.

Having thought a while about this, and based on Mark's previous comment,
I'm thinking of moving this code to another place might not be the best choice,
there are two other ways out from my POV:

1. having mfp.c export mfp_config() for external usage
2. or having something like IrDA, i.e. platform specific hooks to make
the driver code generic

I personally prefer way 2) but don't have time for a clean solution yet,
maybe you can help take a look into this. That would be nice.

- eric

More information about the Alsa-devel mailing list