[alsa-devel] [PATCH] beyond ARRAY_SIZE of s3c64xx_i2s

Roel Kluin roel.kluin at gmail.com
Wed May 20 17:09:50 CEST 2009


Do not go beyond ARRAY_SIZE of s3c64xx_i2s

Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
---
In this case you are Maintainer, correct?

diff --git a/sound/soc/s3c24xx/s3c64xx-i2s.c b/sound/soc/s3c24xx/s3c64xx-i2s.c
index 33c5de7..f2d3021 100644
--- a/sound/soc/s3c24xx/s3c64xx-i2s.c
+++ b/sound/soc/s3c24xx/s3c64xx-i2s.c
@@ -126,7 +126,7 @@ static int s3c64xx_i2s_probe(struct platform_device *pdev,
 
 	dev_dbg(dev, "%s: probing dai %d\n", __func__, pdev->id);
 
-	if (pdev->id < 0 || pdev->id > ARRAY_SIZE(s3c64xx_i2s)) {
+	if (pdev->id < 0 || pdev->id >= ARRAY_SIZE(s3c64xx_i2s)) {
 		dev_err(dev, "id %d out of range\n", pdev->id);
 		return -EINVAL;
 	}


More information about the Alsa-devel mailing list