[alsa-devel] [PATCH 0/2] ASoC: TWL4030: DAPM restructuring and Headset pop-attenuation fix

Peter Ujfalusi peter.ujfalusi at nokia.com
Wed May 20 11:08:25 CEST 2009


On Wednesday 20 May 2009 11:21:02 ext Aggarwal, Anuj wrote:

> [Aggarwal, Anuj] Since different platforms are using different ramp values,
> how should it be handled via the same codec source code? How should this be
> done, without modifying the code base? Or should it be done every time user
> wants to play an audio file?

I think we should leave the ramp delay configurable, since it is easier to 
'port' the codec to a new board.
We can add - as Mark already suggested - a platform data parameter for the 
twl4030 codec driver to set the correct ramp delay value for the given board. 
The actual user will still have means to change it, but if the correct ramp 
delay has been found for the board, the pop attenuation would work out of box 
on the boards. 

-- 
Péter


More information about the Alsa-devel mailing list