[alsa-devel] [PATCH 3/3] ASoC: SDP3430: Connect twl4030 voice DAI to McBSP3
Lopez Cruz, Misael
x0052729 at ti.com
Mon May 18 18:23:34 CEST 2009
> > /* Add SDP3430 specific widgets */
> > @@ -150,6 +194,11 @@ static int sdp3430_twl4030_init(struct
> > snd_soc_codec
> > *codec) /* Set up SDP3430 specific audio path audio_map */
> > snd_soc_dapm_add_routes(codec, audio_map,
> > + /* Enable audio interface */
> > + reg = codec->read(codec, TWL4030_REG_AUDIO_IF);
> > + reg |= TWL4030_AIF_EN;
> > + codec->write(codec, TWL4030_REG_AUDIO_IF, reg);
> > +
> Well, this does not do anything (bad or good)... The Audio
> interface is permanently enabled by default (by the default
> register array in the twl4030.c).
> I have plans to do it dynamically, but it needs some more
> thinking, since the digital loopback on the audio path needs
> also the audio interface to be enabled.
> Is there a reason to do this at all?
I thought in enabling the audio interface in machine driver
and clean AUDIO_IF reg in register cache, but that would require
to enable it in all other machine drivers. However, I didn't
consider the digital loopback scenario.
So, I'll remove this from machine driver and resend it.
More information about the Alsa-devel