[alsa-devel] [PATCH 1/4 v3] pxa2xx-i2s: Proper hw initialization

Karl Beldan karl.beldan at gmail.com
Thu May 14 10:37:41 CEST 2009


Karl Beldan wrote:
> Make sure we are in a know good state at end of probe :
> Reset FIFO logic and registers, and make sure REC and RPL functions
> along with FIFO service are disabled (SACR0_RST enables REC and RPL).
> 
> Resetting loses current settings so remove reset from stream startup.
> Now reset occurs only at probe.
> 

This differs from what you applied in that it includes 'removal of hw reset from
pxa2xx_i2s_startup'.
I understood including it in either one (1/4 or 2/4) is ok, since you had not
pushed it yet. Otherwise I'll have to post a [PATCH 2/4 v3] including the reset,
which would be identical to [PATCH 2/4] (initial version).
If I understand correctly from your replies, I should have posted [PATCH 1/4
v2]'s content with [PATCH 1/4 v3]'s Subject.

Thanks,

-- 
Karl


More information about the Alsa-devel mailing list