[alsa-devel] [PATCH 2/4] pxa2xx-i2s: Handle SACR1_DRPL and SACR1_DREC separately

Mark Brown broonie at sirena.org.uk
Tue May 12 12:32:43 CEST 2009

On Tue, May 12, 2009 at 11:59:03AM +0200, Karl Beldan wrote:
> Mark Brown wrote:

> > That doesn't seem to tie up - I can see the initialisation changing the
> > behaviour on first run but it seems surprising that this should happen
> > on subsequent runs too.  Alternatively, is your initialisation patch
> > safe to apply by itself?

> Well 2/4 stops the clocks only if both REC and RPL are disabled.
> Without 1/4 you end up with REC enabled at startup.
> In a scenario where you have never used REC you end up RPLing with REC always on.
> REC being on at shutdown(),clocks won't stop.

Yet they are being stopped by something...

> > As previously discussed you need to rework the patch to not do the reset
> > on initial probe not when the module is loaded, you need to address this
> > rather than reposting.

> The patch in question is moving the reset in probe rather than module init - with comment updated.
> What is wrong ?

A repost is where you send exactly the same thing again.  When you say
you're reposting something it means you've not made any changes; if you
say that's what you're doing and your code has problems that need to be
fixed it's fairly obvious that all the previous comments are going to
continue to apply.

> > I'll try to find time to re-review the series but I'm going to need to
> > sit down with the datasheet and check this in much more detail.

> For 1/4 and 2/4 there should not be great need, Really.

There's been enough stuff with the series that I've got a few alarm
bells ringing, if only with obscure relationships between the patches.

More information about the Alsa-devel mailing list