[alsa-devel] [PATCH 2/4] pxa2xx-i2s: Handle SACR1_DRPL and SACR1_DREC separately

Mark Brown broonie at sirena.org.uk
Tue May 12 10:58:39 CEST 2009

On Tue, May 12, 2009 at 12:00:33AM +0200, Karl Beldan wrote:

> Then it is perfectly normal since reset enables both REC and RPL, 2/4 needs 1/4.
> The current tree disables the clocks anytime one function is disabled.

That doesn't seem to tie up - I can see the initialisation changing the
behaviour on first run but it seems surprising that this should happen
on subsequent runs too.  Alternatively, is your initialisation patch
safe to apply by itself?

> I resent 1/4 and will make it 1/5 with the whole serie once everything is Clear.

As previously discussed you need to rework the patch to not do the reset
on initial probe not when the module is loaded, you need to address this
rather than reposting.

I'll try to find time to re-review the series but I'm going to need to
sit down with the datasheet and check this in much more detail.

More information about the Alsa-devel mailing list