[alsa-devel] patch to support Samsung NC10 mini notebook
tiwai at suse.de
Tue May 12 08:13:12 CEST 2009
At Mon, 11 May 2009 22:25:14 +0200,
Chris Pockele wrote:
> >> [ALC663_ASUS_MODE6] = "asus-mode6",
> >> + [ALC272_DELL] = "dell272",
> >> + [ALC272_DELL_ZM1] = "dell-zm1",
> > These models have been already added pretty recently.
> > Please rebase your patch with the latest snapshot.
> I rebased using 20090509 snapshot before sending the patch (I checked
> out today's snapshot too - patch_realtek.c hasn't changed), and those
> models were there indeed. However, I wanted to try those
> configurations but I couldn't use the model= option because the
> configurations were not in the alc662_models array. That's why I
> added these 2 lines, and it got through to the patch. I removed them
> for now, as that should probably be another patch.
Hm, the model strings should have been there, at least, in
alsa-driver-snapshot.tar.gz. The snapshot.tar.gz is always the latest
tarball. Anyway, the change is trivial, so I fixed manually.
> >> + [ALC272_SAMSUNG_NC10] = "samsung-nc10",
> > Also, don't forget to update
> > Documentation/sound/alsa/HD-Audio-Models.txt, too.
> > Could you fix the issues above and repost?
> The attached version fixes all issues you mentioned.
Thanks! Now applied to sound git tree.
More information about the Alsa-devel