[alsa-devel] [PATCH] AFEB9260 ASoC driver

[Sergey Lapin]

On Thu, May 07, 2009 at 04:46:11PM +0100, Mark Brown wrote:
> On Thu, May 07, 2009 at 05:24:45PM +0400, Sergey Lapin wrote:
> > ASoC driver for AT91SAM9260-based AFEB9260 board
> 
> This looks good - there's some issues below but they're all pretty
> nitpicky.
> 
> >  static struct i2c_board_info __initdata afeb9260_i2c_devices[] = {
> >  	{
> > +		I2C_BOARD_INFO("tlv320aic23", 0x1a),
> > +	}, {
> 
> Push this separately via arch/arm - there's no build time dependency
> here and it'll avoid any merge issues.
Ok, will submit this separately.

> > +static void __exit afeb9260_soc_exit(void)
> > +{
> > +	platform_device_unregister(afeb9260_snd_device);
> > +}
> 
> Do you want to reverse your requst of the SSC port here?
What would you suggest alternatively?

All the best,
S.