[alsa-devel] [PATCH 2/4] pxa2xx-i2s: Handle SACR1_DRPL and SACR1_DREC separately

Mark Brown broonie at sirena.org.uk
Fri May 8 12:42:29 CEST 2009

On Fri, May 08, 2009 at 01:53:47AM +0200, Karl Beldan wrote:
> - hw_params enables both RPL and REC functions each time,
> enable the appropriate function in pxa2xx_i2s_trigger.
> - pxa2xx_i2s_shutdown disables i2s anytime one of RPL or REC
> function is off, turn it off only when both functions are off.

Looks OK, but...

> - do not put the clk_i2s for no reason in pxa2xx_i2s_shutdown.

...this really ought to be a separate patch.  I'll wait until Monday
when I'm back in the office before applying so I can test.

More information about the Alsa-devel mailing list