[alsa-devel] [PATCH] AFEB9260 ASoC driver

[Mark Brown]

On Thu, May 07, 2009 at 05:24:45PM +0400, Sergey Lapin wrote:
> ASoC driver for AT91SAM9260-based AFEB9260 board

This looks good - there's some issues below but they're all pretty
nitpicky.

>  static struct i2c_board_info __initdata afeb9260_i2c_devices[] = {
>  	{
> +		I2C_BOARD_INFO("tlv320aic23", 0x1a),
> +	}, {

Push this separately via arch/arm - there's no build time dependency
here and it'll avoid any merge issues.

>  obj-$(CONFIG_SND_AT91_SOC_SAM9G20_WM8731) += snd-soc-sam9g20-wm8731.o
>  obj-$(CONFIG_SND_AT32_SOC_PLAYPAQ) += snd-soc-playpaq.o
> +obj-$(CONFIG_SND_AT91_SOC_AFEB9260) += afeb9260.o

Normally ASoC drivers have a snd-soc- prefix.

> +/*
> + * afeb9260.c  --  SoC audio for AFEB9260
> + *
> + * Copyright (C) 2008 Sergey Lapin <slapin at ossfans.org>

2009?

> +static int afeb9260_startup(struct snd_pcm_substream *substream)
> +{
> +	return 1;
> +}

This is unneeded and should be removed.

> +static void afeb9260_shutdown(struct snd_pcm_substream *substream)
> +{
> +	struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
> +
> +	dev_dbg(rtd->socdev->dev, "shutdown");
> +}

This too.

> +static int afeb9260_tlv320aic23_init(struct snd_soc_codec *codec)
> +{
> +
> +	/* Add osk5912 specific widgets */
> +	snd_soc_dapm_new_controls(codec, tlv320aic23_dapm_widgets,
> +				  ARRAY_SIZE(tlv320aic23_dapm_widgets));

Cut'n'paste error in the comments (and in a few other places) :)

> +static void __exit afeb9260_soc_exit(void)
> +{
> +	platform_device_unregister(afeb9260_snd_device);
> +}

Do you want to reverse your requst of the SSC port here?