[alsa-devel] [PATCH 1/2] ASoC: cs4270: introduce CS4270_I2C_INCR

Daniel Mack daniel at caiaq.de
Tue May 5 17:15:38 CEST 2009


On Tue, May 05, 2009 at 09:51:47AM -0500, Timur Tabi wrote:
> Daniel Mack wrote:
> > Replace the magic 0x80 value with a suitable macro definition.
> > 
> > Signed-off-by: Daniel Mack <daniel at caiaq.de>
> > Cc: Timur Tabi <timur at freescale.com>
> > Cc: Mark Brown <broonie at sirena.org.uk>
> 
> And I thought *I* was anal-retentive! :-)

Erm, yes - need to explain that :)

I planned to use that macro a second time for the register write-back at
resume time. But unfortunately, the i2c stack is so badly broken that it
does not allow the write of a whole data block without having the length
itself as part of the message (which is wrong for the codec).

But the change was there already by then, and so I left the patch in my
queue.

Daniel



More information about the Alsa-devel mailing list