[alsa-devel] [ASoC PATCH 1/1] IMote 2 ASoC Support
jic23 at cam.ac.uk
Mon May 4 16:42:27 CEST 2009
Mark Brown wrote:
> On Mon, May 04, 2009 at 02:38:00PM +0000, Jonathan Cameron wrote:
>> + /* Disable the PLL */
>> + ret = snd_soc_dai_set_pll(codec_dai, 0, 0, 0);
>> + if (ret < 0)
> This seems very odd - the PLL is never enabled by your driver but you go
> through and explicitly disable it every time the driver is configured.
Fair point. It's a legacy from trying to test with it set up differently.
I'll clear that out as it's only going to cause confusion.
> Other than that this looks fine; you're including more headers than you
> really need but that shouldn't do any harm.
Oops, will clean them up.
More information about the Alsa-devel