[alsa-devel] [RESEND] [PATCH] pxa2xx-ac97: fix displaying GSR after reset timeout
Russell King - ARM Linux
linux at arm.linux.org.uk
Tue Mar 24 23:18:41 CET 2009
On Tue, Mar 24, 2009 at 05:25:28PM +0100, Luotao Fu wrote:
> the variable gsr_bit is set in isr. It is however set to 0 and interrupts are
> disabled prior to reset on pxa27x and pxa3xx. Hence it doesn't make a lot of
> sense to show the content of gsr_bit in case of a reset timeout.
It would make more sense to put "GSR | gsr_bits" into a temporary variable
for testing, and then printing so that the value printed is the exact
value which was tested, not somehting that may have changed.
Also, you've resent your patch but omitted the ALSA mailing list.
More information about the Alsa-devel