[alsa-devel] [PATCH 0/9] ARM: DaVinci: ASoC: Adds Audio support for TI DM646X

Medisetty, Naresh naresh at ti.com
Wed Mar 18 13:32:01 CET 2009


Thanks for the review.

I will re-submit the series by taking care of  your comments.

> -----Original Message-----
> From: naresh [mailto:x0090427 at ti.com]
> Sent: Wednesday, March 18, 2009 5:50 PM
> To: 'naresh at ti.com'<mailto:'naresh at ti.com'>
> Subject:
> On Mon, Mar 16, 2009 at 08:00:54AM -0400, Naresh Medisetty wrote:
> > Adds Audio support for TI DM646X EVM platform
> > Signed-off-by: Naresh Medisetty <naresh at ti.com<mailto:naresh at ti.com>>
> I'm broadly OK with anything I haven't specifically commented on here.
> However, the ASoC bits of the series need to be updated to reflect the
> current ASoC APIs.  Some additional documentation for your changes to
> the EVM would be very helpful.

I will take elaborate the documentation while re-submitting the patches

> It would also be very much better if you could restructure the series
> to
> reflect the changes you're making.  You're actually doing three things:
>  - Add support for a dummy codec.
>  - Add support for the McASP port on the DaVinci.
>  - Update the DaVinci EVM driver to use these two things on relevant
>    EVMs.
> and the series should be structured to reflect this.  The codec and EVM
> support should each go in a single patch by themselves.  The McASP
> support is big enough to be broken down but it does need to come before
> the EVM support that uses it.

I will structure the series according to this.

More information about the Alsa-devel mailing list