[alsa-devel] [PATCH 2/3][RFC] ASoC: Add Magician machine support.

[Liam Girdwood]

On Wed, 2009-03-11 at 22:25 +0000, Mark Brown wrote:
> On Wed, Mar 11, 2009 at 07:16:59PM +0100, Philipp Zabel wrote:
> 
> This is all good except you're missing updates for a few new APIs:
> 
> > +	/* NC codec pins */
> > +	snd_soc_dapm_disable_pin(codec, "VOUTLHP");
> > +	snd_soc_dapm_disable_pin(codec, "VOUTRHP");
> 
> snd_soc_dapm_nc_pin() (currently a synonym but hopefully in the future
> it will gain support for things like masking out controls for that path
> from the UI.
> 
> > +	/* Add magician specific controls */
> > +	for (i = 0; i < ARRAY_SIZE(uda1380_magician_controls); i++) {
> > +		err = snd_ctl_add(codec->card,
> > +				  snd_soc_cnew(&uda1380_magician_controls[i],
> > +						codec, NULL));
> > +		if (err < 0)
> > +			return err;
> > +	}
> 
> snd_soc_add_controls()

I'm thinking we should probably make snd_soc_cnew() static now. It's far
more convenient to use snd_soc_add_controls().

> 
> > +	ret = gpio_request(EGPIO_MAGICIAN_CODEC_RESET, "CODEC_RESET");
> > +	if (ret)
> > +		goto err_request_reset;
> 
> Someone needs to write a bulk GPIO request API...  not an issue for
> merging this patch, though.

My thoughts exactly :)

Liam