[alsa-devel] [PATCH 2/3][RFC] ASoC: Add Magician machine support.

[Liam Girdwood]

Overall looks good. One very minor issue :-

On Wed, 2009-03-11 at 19:16 +0100, Philipp Zabel wrote:
> HTC Magician has a Philips UDA1380 codec connected via
> SSP1 (playback) and I2S (capture).
> There is a flip-flop between the SSP frame clock output
> and the codec's word select input pin. To make the codec
> see proper I2S input, the SSP has to send two frames per
> sample.
> 
> Signed-off-by: Philipp Zabel <philipp.zabel at gmail.com>
> ---
>  sound/soc/pxa/Kconfig    |   10 +
>  sound/soc/pxa/Makefile   |    2 +
>  sound/soc/pxa/magician.c |  563 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 575 insertions(+), 0 deletions(-)
>  create mode 100644 sound/soc/pxa/magician.c
> 

snip

> --- /dev/null
> +++ b/sound/soc/pxa/magician.c
> @@ -0,0 +1,563 @@
> +/*
> + * SoC audio for HTC Magician
> + *
> + * Copyright (c) 2006-2009 Philipp Zabel <philipp.zabel at gmail.com>
> + *
> + * based on spitz.c,
> + * Authors: Liam Girdwood <liam.girdwood at wolfsonmicro.com>

This address is no longer valid. Could you change to the address I'm
sending with.

Thanks

Liam