[alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

Kevin Hilman khilman at deeprootsystems.com
Tue Mar 10 17:08:38 CET 2009

Mark Brown <broonie at sirena.org.uk> writes:

> On Tue, Mar 10, 2009 at 08:55:06AM -0700, Kevin Hilman wrote:
>> On a related note, sound/soc/davinci/davinci-[evm,sffsdr].c is
>> actually board-level setup code and should not actually live in
>> sound/asoc/.  It should live in arch/arm/mach-davinci/* and follow the
>> rest of the davinci chip/board code upstream.
> No, the ASoC APIs are not stable enough for this - putting this code in
> arch/arm will just lead to merge pain when code from one tree goes in
> without updates from the other.
> Experience also suggests that audio drivers often get substantial enough
> and need sufficient review to warrant keeping separate from the core
> machine code.

OK, good to know your opinion there.



More information about the Alsa-devel mailing list