[alsa-devel] [PATCH 3/4] pxa-ssp: don't touch ssp registers when stream is running
broonie at sirena.org.uk
Wed Mar 4 21:33:52 CET 2009
On Wed, Mar 04, 2009 at 09:16:59PM +0100, Daniel Mack wrote:
> In pxa_ssp_set_dai_fmt(), don't modify the SSP registers in case the
> stream is already running. With that patch applied, loop-thru tests like
> 'acrecord -f cd | aplay -f cd' succeed.
> + /* we can only change the settings if the port is not in use */
> + if (ssp_read_reg(ssp, SSCR0) & SSCR0_SSE)
> + return 0;
I'd expect an error to be reported here - if we needed to change the
settings and can't things could go wrong. Ideally it'd check to see if
the DAI format was being changed and only error if it was.
More information about the Alsa-devel