[alsa-devel] [PATCH 2/4] ASoC: UDA1380: DATAI is slave only

[pHilipp Zabel]

On Tue, Mar 3, 2009 at 4:50 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Mar 03, 2009 at 04:10:52PM +0100, Philipp Zabel wrote:
>
>> -     if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) == SND_SOC_DAIFMT_CBM_CFM)
>> -             iface |= R01_SIM;
>> +     /* DATAI is slave only, so in single-link mode, this has to be slave */
>> +     if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) != SND_SOC_DAIFMT_CBS_CFS)
>> +             return -EINVAL;
>
> Hrm, is R01_SIM not required to be set?  I've no idea what it does so
> quite possibly.

R01_SIM sets the UDA1380's digital output interface to master.
This is not allowed if both input and output use a single DAI
(uda1380_set_dai_fmt_both), because the input interface is slave only.

Only uda1380_set_dai_fmt_capture should accept the CBM_CFM setting.

regards
Philipp