[alsa-devel] [PATCH] ASoC: make ops a pointer in 'struct snd_soc_dai'

Eric Miao eric.y.miao at gmail.com
Tue Mar 3 04:33:18 CET 2009

On Mon, Mar 2, 2009 at 7:55 PM, Takashi Iwai <tiwai at suse.de> wrote:
> At Mon, 2 Mar 2009 11:25:46 +0800,
> Eric Miao wrote:
>> Considering the fact that most cpu_dai or codec_dai are using a same
>> 'snd_soc_dai_ops' for several similar interfaces, 'ops' would be better
>> made a pointer instead, to make sharing easier and code a bit cleaner.
>> The patch below is rather preliminary since the asoc tree is being
>> actively developed, and this touches almost every piece of code,
>> (and possibly many others in development need to be changed as
>> well). Building of all codecs are OK, yet to every SoC, I didn't test
>> that.
>> Signed-off-by: Eric Miao <eric.miao at marvell.com>
> Don't forget to update Documentation/sound/alsa/soc/*, too.
> (I don't mind who does it, though ;)

Yes, I took a rough look into those files, and some of which are
already inconsistent with the existing code. E.g. 'dai_ops' looks
non-existent now, merged into '.ops' already. And other stories
I'm afraid I cann't tell much. So

Liam or Mark,

I'd prefer you guys make those descriptions more consistent if

More information about the Alsa-devel mailing list