[alsa-devel] [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver

Jon Smirl jonsmirl at gmail.com
Tue Jun 30 20:33:18 CEST 2009

On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely<grant.likely at secretlab.ca> wrote:
> On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang<w.sang at pengutronix.de> wrote:
>>> +
>>> +     /* Force clear the data valid bit */
>>> +     in_be32(&psc_dma->psc_regs->ac97_data);
>>> +
>> No mutex involved here. I think this is either a separate patch or it needs at
>> least to be mentioned in the patch description.
> Oops, that was sloppy.  Yes, I'll put this into a separate patch.  Thanks.

Now that you have added the mutexes, do you ever need to force clear
the valid bit?
Maybe log an error if this happens so that we can track down why.

Jon Smirl
jonsmirl at gmail.com

More information about the Alsa-devel mailing list