[alsa-devel] [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname

Jaroslav Kysela perex at perex.cz
Tue Jun 2 12:11:33 CEST 2009


On Tue, 2 Jun 2009, Takashi Iwai wrote:

> At Tue, 2 Jun 2009 11:31:04 +0200,
> Daniel Mack wrote:
>>
>> On Tue, Jun 02, 2009 at 09:49:39AM +0200, Takashi Iwai wrote:
>>>> So what's your suggestion to fix the behaviour I was describing? Maybe a
>>>> combination of Jaroslav's collision detection together with a logic that
>>>> does not touch the id in case it was passed as module option?
>>>
>>> Sounds reasonable.  We may need just a number suffix if any collision
>>> occurs.
>>
>> What about that patch below? Works well in my tests here.
>
> Looks almost good, but we need to check
> snd_info_check_reserved_words() too.
>
> I guess the routine in choose_default_id() can be reused for this
> function, though.
>
> Jaroslav seems working on this now, so maybe he could better cope
> with you...

Daniel, could you test this patch?

http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=5384d153538ef403c5ca51a6e0c8b85b735c877a

 					Thanks,
 						Jaroslav

-----
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.



More information about the Alsa-devel mailing list