[alsa-devel] [PATCH] RESEND: Acer Aspire 8930G support

Takashi Iwai tiwai at suse.de
Tue Jun 2 11:01:36 CEST 2009


At Tue, 02 Jun 2009 10:37:47 +0200,
Hector Martin wrote:
> 
> Takashi Iwai wrote:
> > The changes you made are fine, but could you reformat the patch as
> > checkpatch.pl-clean and repost?
> 
> Done.
> 
> -	spec->multiout.max_channels = spec->channel_mode[0].channels;
> +	if (preset->const_channel_count == 0)

This should be != instead of ==, right?

> +		spec->multiout.max_channels = preset->const_channel_count;
> +	else
> +		spec->multiout.max_channels = spec->channel_mode[0].channels;
> +	spec->ext_channel_count = spec->channel_mode[0].channels;

I applied the patch with slight fix like the above and the reorder of
the quirk entry together with the addition to HD-Audio-Models.txt now.


thanks,

Takashi


More information about the Alsa-devel mailing list