[alsa-devel] [PATCH 3/5] ALSA: snd_usb_caiaq: use strncpy

Takashi Iwai tiwai at suse.de
Mon Jun 1 18:55:23 CEST 2009


At Mon, 1 Jun 2009 11:23:54 +0200,
Daniel Mack wrote:
> 
> On Mon, Jun 01, 2009 at 10:32:21AM +0200, Takashi Iwai wrote:
> > > Signed-off-by: Daniel Mack <daniel at caiaq.de>
> > 
> > You should use strlcpy() instead of strncpy().  The latter doesn't
> > terminate the oversized string.
> 
> Right. Want me to resend or could you do that on the fly while
> commiting?

Well, I'm going to review the whole patches again tomorrow.
Would be nice if you resend the latest fixed ones.


thanks,

Takashi


More information about the Alsa-devel mailing list