[alsa-devel] [PATCH 2/4] Allow passing platform_data for pxa2xx-ac97
marek.vasut at gmail.com
Thu Jul 30 02:55:01 CEST 2009
Dne Út 28. července 2009 07:28:20 Marek Vasut napsal(a):
> Dne Čt 23. července 2009 20:39:37 Marek Vasut napsal(a):
> > Dne Čt 23. července 2009 16:16:12 Marek Vasut napsal(a):
> > > Dne Čt 23. července 2009 12:27:41 Mark Brown napsal(a):
> > > > On Wed, Jul 22, 2009 at 01:02:40PM +0200, Marek Vasut wrote:
> > > > > struct snd_ac97_bus *ac97_bus;
> > > > > struct snd_ac97_template ac97_template;
> > > > > int ret;
> > > > > + pxa2xx_audio_ops_t *pdata = dev->dev.platform_data;
> > > > > + int id = dev->id < 0 ? 0 : dev->id;
> > > >
> > > > dev here is the AC97 controller device - if there's more than one
> > > > AC97 controller in the system they can each have the four child
> > > > devices. On the other hand, I don't think any of the PXA processors
> > > > have more than one AC97 controller so it'll never actually have any
> > > > impact.
> > > >
> > > > I think the best thing for now is to either warn if anything except
> > > > the primary codec has platform data or change the platform data to
> > > > have a variable something like primary_audio_pdata. The driver
> > > > doesn't appear to support secondary codecs anyway.
> > >
> > > Ok, here's a fixed patch.
> > Argh, one more iteration here. There was a typo in the previous patch.
> > Sorry.
> Hi, well ... any updates ? Eric, is this patch ok with you ?
I made one more revision here as in case the platform_data aren't supplied,
the kernel obviously crashes.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3958 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20090730/78badd57/attachment.patch
More information about the Alsa-devel