[alsa-devel] [PATCH 1/3] new ad1938 codec driver based on asoc

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Jul 16 12:09:27 CEST 2009

On Thu, Jul 16, 2009 at 04:00:05PM +0800, Barry Song wrote:
> Signed-off-by: Barry Song <21cnbao at gmail.com>

This is fine from a code point of view but there are a *lot* of
tab/space problems in the code.  I'd suggest running checkpatch over
your patches before sending them to make sure you catch issues like
that.  Also, the patch was against the ASoC dev branch rather than ALSA
git - the most current mailine ALSA code is in the topic/asoc branch of:


Please submit patches againt that or my current queue which will be in:


Since the code is all good I've applied the patch as-is but a followup
fixing the tab/space stuff would be appreciated.

More information about the Alsa-devel mailing list