[alsa-devel] [PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

Rongrong Cao rrcao at ambarella.com
Wed Jul 8 08:11:46 CEST 2009


From: Rongrong Cao rrcao at ambarella.com

This patch is based on for-2.6.32
In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
the original code has wrong logic when dapm layer check each widget whether an external one.

---------------------------------------------------------------------------------------------------------

--- for-2.6.32/sound/soc/soc-dapm.c.orig        2009-07-08 13:33:41.000000000 +0800
+++ for-2.6.32/sound/soc/soc-dapm.c     2009-07-08 13:34:50.000000000 +0800
@@ -1290,8 +1290,8 @@ static int snd_soc_dapm_add_route(struct
        if (wsink->id == snd_soc_dapm_input) {
                if (wsource->id == snd_soc_dapm_micbias ||
                        wsource->id == snd_soc_dapm_mic ||
-                       wsink->id == snd_soc_dapm_line ||
-                       wsink->id == snd_soc_dapm_output)
+                       wsource->id == snd_soc_dapm_line ||
+                       wsource->id == snd_soc_dapm_output)
                        wsink->ext = 1;
        }
        if (wsource->id == snd_soc_dapm_output) {

---------------------------------------------------------------------------------------------------------

Signed-off-by: Rongrong Cao <rrcao at ambarella.com>


********************
Best regards!
Allen (Rongrong) Cao
Ambarella Shanghai Ltd.
Tel:   (86-21) 50942311
Fax:  (86-21) 50942321





More information about the Alsa-devel mailing list