[alsa-devel] [PATCH] [RFC 2/13] Intel SST driver

[Harsha, Priya]

>>
>> >(snip)
>> >> +#ifndef CONFIG_SST_IPC_NOT_INCLUDED
>> >> +#include <asm/ipc_defs.h>
>> >> +#endif
>> >
>> >What is this file?
>> This file has the function definitions to communicate to the sound
>> card. The sound card is a part of PMIC chip. The sound card
>> registers are not accessible by CPU directly. There is a platform
>> driver that enables to communicate to the sound card. Audio driver
>> uses this header file of that diver to communicate to the sound
>> card. This is one of the dependant drivers for audio driver. This is
>> being submitted upstream by Intel as well.
>
>Hm, OK, but then don't forget to remove ifdef after that part is
>merged.  An ifdef around the include file isn't recommended at all.

Sure. Will remove them once the dependent drivers are merged.

>>
>> >
>> >> +#ifdef CONFIG_SST_OSPM_SUPPORT
>> >
>> >Can't be simple CONFIG_PM?
>> No. OSPM is new power management module being developed for the
>> platform. The code defined under this #def is to provide support
>> from audio stack to this new power management module. This is also
>> being up streamed by Intel.
>
>I understand the underlying platform isn't merged so we need another
>ifdef.  But, once after it got merged, no reason to keep another
>special config, right?
>
>Keeping own kconfigs look easy but this will increase maintenance
>labor a lot later.  If it's a power-management, using only CONFIG_PM
>would make the life happier.

Yes. These configs would go when the dependant power management module is merged. 

Thanks,
Harsha