[alsa-devel] [PATCH V1 09/11] ASoC: DaVinci: i2s, add davinci_i2s_prepare and shutdown
broonie at opensource.wolfsonmicro.com
Sun Jul 5 14:17:42 CEST 2009
On Sat, Jul 04, 2009 at 07:29:59PM -0700, Troy Kisky wrote:
> If the codec is master then prepare should call
> mcbsp_start, not trigger.
> Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
This and 1-7 all look good, I've applied them. For this one (and some
of the others) it might've been nice to include a few more words about
> +static void davinci_i2s_shutdown(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct davinci_mcbsp_dev *dev = rtd->dai->cpu_dai->private_data;
No need to bounce through rtd here or in prepare.
More information about the Alsa-devel