[alsa-devel] [PATCH V1 10/11] ASoC: DaVinci: i2s don't limit rates

[Mark Brown]

On Sat, Jul 04, 2009 at 07:30:00PM -0700, Troy Kisky wrote:
> If the codec is master, we support anything
> that the codec supports.

Hrm, tricky - the rate configuration doesn't depend on what is master so
this could cause confusion if the codec is slave.

> -#define DAVINCI_I2S_RATES	SNDRV_PCM_RATE_8000_96000
> +#define DAVINCI_I2S_RATES	(SNDRV_PCM_RATE_8000_96000 |\
> +	SNDRV_PCM_RATE_5512 | SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS)

Note that the ASoC core doesn't support _KNOT or _CONTINUOUS (at least
not properly) so the only thing you should get from this is 5512.  Is
that really worth worrying about the master/slave problem?